Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buku: fix bukuserver (missing module) #74781

Merged
merged 1 commit into from Dec 1, 2019
Merged

Conversation

@dermetfan
Copy link
Member

dermetfan commented Dec 1, 2019

Motivation for this change

bukuserver crashes on startup:

No module named 'flask_admin'
Traceback (most recent call last):
  File "/nix/store/5qi5nyzyj794d90jk4i91xbwnzc8p3qb-buku-4.2.2/bin/.bukuserver-wrapped", line 6, in <module>
    from bukuserver.server import cli
  File "/nix/store/5qi5nyzyj794d90jk4i91xbwnzc8p3qb-buku-4.2.2/lib/python3.7/site-packages/bukuserver/server.py", line 10, in <module>
    from flask_admin import Admin
ModuleNotFoundError: No module named 'flask_admin'

I just had to add the flask-admin package to the wrapper's PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer @Infinisil

add missing python module `flask-admin`
@dermetfan dermetfan force-pushed the dermetfan:fix/bukuserver branch from 5bafec6 to fd2328a Dec 1, 2019
@ofborg ofborg bot requested a review from Infinisil Dec 1, 2019
Copy link
Contributor

matthiasbeyer left a comment

Diff looks good.

@teto

This comment has been minimized.

Copy link
Contributor

teto commented Dec 1, 2019

I confirm the issue and this fixes it as well as passes nix-review.

@teto teto merged commit 83c24ad into NixOS:master Dec 1, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
buku on aarch64-linux Success
Details
buku on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dermetfan dermetfan deleted the dermetfan:fix/bukuserver branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.