Skip to content

Conversation

@dermetfan
Copy link
Member

@dermetfan dermetfan commented Dec 1, 2019

Motivation for this change

bukuserver crashes on startup:

No module named 'flask_admin'
Traceback (most recent call last):
  File "/nix/store/5qi5nyzyj794d90jk4i91xbwnzc8p3qb-buku-4.2.2/bin/.bukuserver-wrapped", line 6, in <module>
    from bukuserver.server import cli
  File "/nix/store/5qi5nyzyj794d90jk4i91xbwnzc8p3qb-buku-4.2.2/lib/python3.7/site-packages/bukuserver/server.py", line 10, in <module>
    from flask_admin import Admin
ModuleNotFoundError: No module named 'flask_admin'

I just had to add the flask-admin package to the wrapper's PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer @infinisil

add missing python module `flask-admin`
@ofborg ofborg bot requested a review from infinisil December 1, 2019 12:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 1, 2019
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good.

@teto
Copy link
Member

teto commented Dec 1, 2019

I confirm the issue and this fixes it as well as passes nix-review.

@teto teto merged commit 83c24ad into NixOS:master Dec 1, 2019
@dermetfan dermetfan deleted the fix/bukuserver branch December 1, 2019 20:02
@arcnmx arcnmx mentioned this pull request Jan 22, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants