Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperopt: init at 0.2.2 #74783

Open
wants to merge 1 commit into
base: master
from

Conversation

@GuillaumeDesforges
Copy link
Contributor

GuillaumeDesforges commented Dec 1, 2019

Motivation for this change

hyperopt was not part of nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Additional information

I have tested the package using the example from hyperopt readme.

@GuillaumeDesforges GuillaumeDesforges force-pushed the GuillaumeDesforges:hyperopt branch from 38134f5 to f3aa7ef Dec 1, 2019
@GuillaumeDesforges GuillaumeDesforges mentioned this pull request Dec 1, 2019
@GuillaumeDesforges

This comment has been minimized.

Copy link
Contributor Author

GuillaumeDesforges commented Dec 1, 2019

This issue is now solved, however there is still a problem with the tests.

The full log is here: https://gist.github.com/GuillaumeDesforges/9aa019307f05d98065d7f4c6f85f4f21

The main issue seems to be that files that are not .py files were not copied for the test.

FileNotFoundError: [Errno 2] No such file or directory: '/build/hyperopt-0.2.2/hyperopt/atpe_models/scaling_model.json'

How can I add them to the list of files to copy ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.