Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdk-pixbuf: fix setup hook #74785

Merged
merged 1 commit into from Dec 1, 2019
Merged

gdk-pixbuf: fix setup hook #74785

merged 1 commit into from Dec 1, 2019

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented Dec 1, 2019

b78e840 tried to make the script better but used the wrong test
syntax: [[ 113 > 99 ]] is false. This caused the librsvg not being added
to $GDK_PIXBUF_MODULE_FILE.

Fixes: #73586 (comment)

cc @Ericson2314 @c0bw3b @d-goldin

b78e840 tried to make the script better but used the wrong test
syntax: [[ 113 > 99 ]] is false. This caused the librsvg not being added
to $GDK_PIXBUF_MODULE_FILE.

Fixes: #73586 (comment)
@d-goldin

This comment has been minimized.

Copy link
Contributor

d-goldin commented Dec 1, 2019

@jtojnar: Great, this looks like exactly the issue. I will give it a quick testrun.

@d-goldin

This comment has been minimized.

Copy link
Contributor

d-goldin commented Dec 1, 2019

Adwaita builds and naturally GDK_PIXBUF_MODULE_FILE points to the correct librsvg loaders.cache 👍

@c0bw3b
c0bw3b approved these changes Dec 1, 2019
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Dec 1, 2019

This can go to master as we currently don't have any staging-next either.

@jtojnar

This comment has been minimized.

Copy link
Contributor Author

jtojnar commented Dec 1, 2019

I think the issue is only in staging at the moment.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Dec 1, 2019

Oh, it builds on other changes in staging. Never mind then.

@FRidh FRidh added this to Ready in Staging Dec 1, 2019
@FRidh FRidh merged commit d4b4bcd into NixOS:staging Dec 1, 2019
16 checks passed
16 checks passed
gdk-pixbuf on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
gdk-pixbuf on aarch64-linux Success
Details
gdk-pixbuf on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Ready to Done Dec 1, 2019
@jtojnar jtojnar deleted the jtojnar:gdk-pixbuf-fix branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.