Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haproxy: 2.0.8 -> 2.0.10, addressing CVE-2019-19330 #74787

Merged
merged 1 commit into from Dec 1, 2019

Conversation

@risicle
Copy link
Contributor

risicle commented Dec 1, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-19330

Supersedes #74420

Planning to patch for stable...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

addressing CVE-2019-19330
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Dec 1, 2019

@GrahamcOfBorg test haproxy

Planning to patch for stable...

Upstream did the job, I would just bump to v1.9.13 on r19.09

@c0bw3b
c0bw3b approved these changes Dec 1, 2019
@c0bw3b c0bw3b merged commit 271b2b2 into NixOS:master Dec 1, 2019
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haproxy on aarch64-linux Success
Details
haproxy on x86_64-linux Success
Details
tests.haproxy on aarch64-linux Success
Details
tests.haproxy on x86_64-linux Success
Details
@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Dec 1, 2019

Upstream did the job, I would just bump to v1.9.13 on r19.09

Oh. Only just read this. I didn't think they had done a backport because I couldn't see stable releases tagged in their repo... but it turns out they keep stable branches in totally separate repos: https://git.haproxy.org/

ffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.