Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
command-not-found: drop perl dependency #74789
Faster startup and remove some perl packages from the default nixos closure.
Motivation for this change
This to me is not really an improvement: it replaces a 51-line Perl script with a 141-line C++ program. As an aside, if we really want to get rid of Perl, then Rust is the way to go IMHO.
BTW, I think we can get rid of the auto-install feature, it was added as a bit of a joke and nobody uses it.
I choose C++:
I am not sure the Rust version would be much shorter. The C++ is now 99 lines compared to 55 lines Perl. But it also generates more error messages and starts faster.
Old closure size: 82.9M
New one is faster but it probably hardly matters:
The C++ program is now +28 lines longer.
Does this looks fine now?
BTW for the record,
Though from my experience it feels somewhat slower to that of the original command-not-found implementation.