Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gegl_0_4: disabling jasper, fixing build #74790

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@d-goldin
Copy link
Contributor

d-goldin commented Dec 1, 2019

Motivation for this change

Jasper has been recently marked as insecure and removed from a bunch
of places due to some known vulnerabilities and upstream not moving
forward. This was done in #73586

This prevents gegl_0_4 from building, as jasper is a runtime dependency
per default. There is an upstream issue for that, but it does not seem
to have made progress yet: https://gitlab.gnome.org/GNOME/gegl/issues/35

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @c0bw3b @jtojnar

Jasper has been recently marked as insecure and removed from a bunch
of places due to some known vulnerabilities and upstream not moving
forward. This was done in #73586

This prevents gegl_0_4 from building, as jasper is a runtime dependency
per default. There is an upstream issue for that, but it does not seem
to have made progress yet: https://gitlab.gnome.org/GNOME/gegl/issues/35
@d-goldin d-goldin force-pushed the d-goldin:gegl_0_4_jasper branch from 685ab24 to c9841ed Dec 1, 2019
@ofborg ofborg bot requested a review from jtojnar Dec 1, 2019
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Dec 1, 2019

👍
jasper previously managed to be in the build scope through gdk-pixbuf -> librsvg apparently

@jtojnar
jtojnar approved these changes Dec 1, 2019
@c0bw3b c0bw3b added this to WIP in Staging via automation Dec 1, 2019
@c0bw3b c0bw3b moved this from WIP to Ready in Staging Dec 1, 2019
@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Dec 2, 2019

This should go to staging-next now. #74795

@jtojnar jtojnar changed the base branch from staging to staging-next Dec 2, 2019
@ofborg ofborg bot requested a review from jtojnar Dec 2, 2019
@jtojnar jtojnar merged commit 65a0078 into NixOS:staging-next Dec 2, 2019
15 of 16 checks passed
15 of 16 checks passed
gegl_0_4 on x86_64-darwin
Details
gegl_0_4 on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
gegl_0_4 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Ready to Done Dec 2, 2019
@d-goldin

This comment has been minimized.

Copy link
Contributor Author

d-goldin commented Dec 2, 2019

@jtojnar: Oh, sorry, I thought this was for the author of the staging-next PR to cherry-pick. Thanks for handling it.

@d-goldin d-goldin deleted the d-goldin:gegl_0_4_jasper branch Dec 2, 2019
@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Dec 2, 2019

If it fixes a direct breakage in staging-next, it is better to fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.