Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statserial: init at 1.1 #74791

Closed
wants to merge 0 commits into from
Closed

statserial: init at 1.1 #74791

wants to merge 0 commits into from

Conversation

@robertseaton
Copy link
Contributor

robertseaton commented Dec 1, 2019

Motivation for this change
Things done
  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x ] Ensured that relevant documentation is up to date
  • [ x ] Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

stigtsp left a comment

Tested:

  • Builds on x86_64-linux OK
  • Tested statserial executable with USB serial dongle, appears to work OK

Result of nix-review pr 74791 1

1 package were build:
  • statserial
'';

meta = with stdenv.lib; {
homepage = https://sites.google.com/site/tranter/software;

This comment has been minimized.

Copy link
@stigtsp

stigtsp Dec 5, 2019

Member

Please quote the URL NixOS/rfcs#45

@stigtsp
stigtsp approved these changes Dec 5, 2019
Copy link
Member

stigtsp left a comment

Looks good to me

Copy link
Member

stigtsp left a comment

The PR contains 3 commits right now, can you squash them into one instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.