Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtermkey: compile with unibilium #74801

Merged
merged 1 commit into from Dec 5, 2019
Merged

libtermkey: compile with unibilium #74801

merged 1 commit into from Dec 5, 2019

Conversation

@teto
Copy link
Contributor

teto commented Dec 1, 2019

While working on neovim, I noticed the functionaltests were failing neovim/neovim#11429. There are bugs in libtermkey that can't load the terminfo driver for some values of TERM. As per libtermkey's author:

To be honest, unibilium is basically a requirement now. I
might just change the code to throw away the other bits and make it a
dependency.

building with unibilium solved all my issues.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

c0bw3b left a comment

While we have a PR open for this package, could you also set meta.homepage ?

pkgs/development/libraries/libtermkey/default.nix Outdated Show resolved Hide resolved
@teto teto force-pushed the teto:fix_libtermkey branch from 58bdcf5 to 2ebb5ef Dec 5, 2019
@teto

This comment has been minimized.

Copy link
Contributor Author

teto commented Dec 5, 2019

@GrahamcOfBorg build libtermkey

As the alternative isn't well tested and will be ruled out very soon.
@c0bw3b
c0bw3b approved these changes Dec 5, 2019
@teto teto merged commit 9c6ceb5 into NixOS:master Dec 5, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libtermkey on aarch64-linux Success
Details
libtermkey on x86_64-darwin Success
Details
libtermkey on x86_64-linux Success
Details
@teto teto deleted the teto:fix_libtermkey branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.