Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Athame-zsh #74804

Open
wants to merge 3 commits into
base: master
from
Open

NEW Athame-zsh #74804

wants to merge 3 commits into from

Conversation

@BananchickPasha
Copy link

BananchickPasha commented Dec 1, 2019

Motivation for this change

There wasn't this package so i decided to add it

Things done

It works, but user has to create ~/.athamerc manually.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ahiaao

This comment has been minimized.

Copy link
Contributor

ahiaao commented Dec 1, 2019

I recommend rereading CONTRIBUTING.md. Specifically the sections about commit messages and meta.description.

This does not seem to respect the directory structure. Maybe move pkgs/shells/zsh/athame-zsh.nix to pkgs/shells/zsh/zsh-athame/default.nix

athame and vimbed should probably be packaged separately.

Do you actually need to override zsh? The other zsh addons do not seem to need to do this.

Are you able to reference the patch you are applying in postPatch in the actual patch stage? Also are two of those lines in postPatch just comments? If so, then those should be removed.

@@ -0,0 +1,39 @@
{stdenv, vim, zsh, ncurses, isNeovim ? false}:
let athame = fetchGit {

This comment has been minimized.

Copy link
@prusnak

prusnak Dec 2, 2019

Member

use fetchFromGitHub

rev = "ded4200cb3312334d99ace794c4b308cd45f6b6e";
url = "https://github.com/ardagnir/athame";
};
vimbed = fetchGit {

This comment has been minimized.

Copy link
@prusnak

prusnak Dec 2, 2019

Member

use fetchFromGitHub

@@ -7670,4 +7670,9 @@
githubId = 52650;
name = "Marc Busqué";
};
bananPasha = {

This comment has been minimized.

Copy link
@prusnak

prusnak Dec 2, 2019

Member

use BananchickPasha instead of bananPasha to match the GitHub username

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.