Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: gdb: Make target-independent and auto-load-safe-path with a wrapper #74808

Open
wants to merge 1 commit into
base: staging
from

Conversation

@Ericson2314
Copy link
Member

Ericson2314 commented Dec 1, 2019

Motivation for this change

The libgcc/compiler-rt used varies with the target platform.

I checked, and lldb doesn't have a similar notion of load prefix path,
so this stays a one-off wrapper for gdb for now.

Need to test to make sure all cross stuff works as expected.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

The libgcc/compiler-rt used varies with the target platform.

I checked, and lldb doesn't have a similar notion of load prefix path,
so this stays a one-off wrapper for gdb for now.
, gdb-unwrapped
, safePaths ? [
# $debugdir:$datadir/auto-load are whitelisted by default by GDB
"$debugdir" "$datadir/auto-load"

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer Dec 2, 2019

Member

These shouldn't be needed when you don't pass the with-auto-load-safe-path option.

This comment has been minimized.

Copy link
@Ericson2314

Ericson2314 Dec 4, 2019

Author Member

Yes thank you I accidentally added them back when I rebased.

@FRidh FRidh moved this from WIP to Needs review in Staging Dec 31, 2019
@FRidh FRidh moved this from Needs review to WIP in Staging Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
WIP
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.