Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpupower: explicitly set CC and LD to allow compilation with e… #74810

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@xaverdh
Copy link
Contributor

xaverdh commented Dec 1, 2019

Motivation for this change

I tried building linuxPackages with clang. cpupower failed to build, because it tries to use gcc.

Things done

I verified that cpupower builds with clang stdenv (version 9) and successfully built linuxPackages_5_4 with these changes (actually I am writing this on a system with clang built kernel right now).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Dec 1, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/compiling-the-linux-kernel-with-clang-llvm/4218/3

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2019

@GrahamcOfBorg build cpupower

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2019

@GrahamcOfBorg build linuxPackages.cpupower

@Mic92 Mic92 changed the title cpupower: explicitly set CC and LD to allow compilation with e.g. clang cpupower: explicitly set CC and LD to allow compilation with e… Dec 2, 2019
@Mic92 Mic92 merged commit 2e64e97 into NixOS:master Dec 2, 2019
18 of 19 checks passed
18 of 19 checks passed
linuxPackages.cpupower on x86_64-linux
Details
cpupower on aarch64-linux No attempt
Details
cpupower on x86_64-darwin No attempt
Details
cpupower on x86_64-linux No attempt
Details
linuxPackages.cpupower on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
linuxPackages.cpupower on aarch64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.