Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-completion: Fix tests with musl. #74813

Merged
merged 1 commit into from Dec 2, 2019
Merged

Conversation

@nh2
Copy link
Contributor

nh2 commented Dec 2, 2019

Motivation for this change

Fixes test error

self = <test_iconv.TestIconv object at 0x7ffff52f3410>
completion = <CompletionResult []>

    @pytest.mark.complete("iconv -")
    def test_1(self, completion):
>       assert completion
E       assert <CompletionResult []>

../t/test_iconv.py:7: AssertionError

by applying upstream commit not present in a newer release.

See

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

@nh2 nh2 requested a review from peti Dec 2, 2019
@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Dec 2, 2019

Still building for me.

@GrahamcOfBorg build pkgsMusl.bash-completion

Fixes test error

    self = <test_iconv.TestIconv object at 0x7ffff52f3410>
    completion = <CompletionResult []>

        @pytest.mark.complete("iconv -")
        def test_1(self, completion):
    >       assert completion
    E       assert <CompletionResult []>

    ../t/test_iconv.py:7: AssertionError

by applying upstream commit not present in a newer release.
@nh2 nh2 force-pushed the nh2:musl-bash-completion-patch branch from 88df6d2 to 0a85437 Dec 2, 2019
@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Dec 2, 2019

@GrahamcOfBorg build pkgsMusl.bash-completion

@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Dec 2, 2019

Still building for me.

Done now.

@Mic92 Mic92 merged commit 0106804 into NixOS:master Dec 2, 2019
16 checks passed
16 checks passed
pkgsMusl.bash-completion on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
bash-completion on aarch64-linux Success
Details
bash-completion on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pkgsMusl.bash-completion on x86_64-linux Success
Details
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2019

I changed it to be applied unconditionally: 8031617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.