Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.fido2: 0.7.3 -> 0.8.1 #74816

Merged
merged 1 commit into from Dec 2, 2019
Merged

python3Packages.fido2: 0.7.3 -> 0.8.1 #74816

merged 1 commit into from Dec 2, 2019

Conversation

@prusnak
Copy link
Member

prusnak commented Dec 2, 2019

Motivation for this change

Version update, fixes #74805

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 2, 2019

@GrahamcOfBorg build python2Packages.fido2
@GrahamcOfBorg build python3Packages.fido2

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 2, 2019

@GrahamcOfBorg build yubioath-desktop python2Packages.solo-python python3Packages.solo-python yubikey-manager-qt yubikey-manager gen-oath-safe

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 2, 2019

Hate to pick on bugfix, but this appears to be breaking python3Packages.solo-python. I made an upstream issue solokeys/solo-python#49
Also cc @wucke13

@prusnak

This comment has been minimized.

Copy link
Member Author

prusnak commented Dec 2, 2019

As solo-python is unusable anyway (because its dependency does not build), I'd say let's merge this and fix solo-python later (once upstream fixes the issue).

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 2, 2019

@prusnak Well, there is an alternative of reverting a8d207c that would fix all of the packages. Unfortunately, there doesn't seem to be a way to prevent automated fido2 bump from landing on master again, so I'm leaning towards merging this as well.

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 2, 2019

Actually, there seems to be a fix: solokeys/solo-python#47

@veprbl veprbl merged commit e678aad into NixOS:master Dec 2, 2019
22 checks passed
22 checks passed
gen-oath-safe, python2Packages.solo-python, python3Packages.solo-python, yubikey-manager, yubikey-manager-qt, yubioath-desktop on aarch64-linux Failure
Details
gen-oath-safe, python2Packages.solo-python, python3Packages.solo-python, yubikey-manager, yubikey-manager-qt, yubioath-desktop on x86_64-darwin Failure
Details
gen-oath-safe, python2Packages.solo-python, python3Packages.solo-python, yubikey-manager, yubikey-manager-qt, yubioath-desktop on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python2Packages.fido2 on aarch64-linux Success
Details
python2Packages.fido2 on x86_64-darwin Success
Details
python2Packages.fido2 on x86_64-linux Success
Details
python3Packages.fido2 on aarch64-linux Success
Details
python3Packages.fido2 on x86_64-darwin Success
Details
python3Packages.fido2 on x86_64-linux Success
Details
@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 2, 2019

@prusnak Thank you!

@prusnak prusnak deleted the prusnak:python-fido2 branch Dec 2, 2019
@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 2, 2019

Opened issue to track solo-python: #74835

@jtojnar jtojnar mentioned this pull request Dec 2, 2019
0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.