Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.irmin: init at 1.4.0 #74818

Merged
merged 5 commits into from Dec 24, 2019
Merged

Conversation

@alexfmpe
Copy link
Member

alexfmpe commented Dec 2, 2019

Motivation for this change

Dependency of tezos

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@yorickvP

This comment has been minimized.

Copy link
Contributor

yorickvP commented Dec 2, 2019

Hi there! Are you packaging tezos? We did this work a while ago. Managed to produce some static binaries for it, too. Here's the set of overrides we used to get it to build

@yorickvP

This comment has been minimized.

Copy link
Contributor

yorickvP commented Dec 2, 2019

Also, feel free to cherry-pick some of https://github.com/serokell/nixpkgs/commits/ocaml-cross-fixes

@alexfmpe

This comment has been minimized.

Copy link
Member Author

alexfmpe commented Dec 2, 2019

Hi there! Are you packaging tezos? We did this work a while ago. Managed to produce some static binaries for it, too. Here's the set of overrides we used to get it to build

Yeah, kind of. I did something similar to that gist to get dune build to work at the root (using mainnet so far), and thought I might as well upstream the derivations. Yours seem slightly more up-to-date though, I haven't needed ipaddr 4.0.0 for instance (though the dune file does state >= 4.0). Admittedly I haven't actually checked anything other than "does this actually produce a working binary" yet.

Also, feel free to cherry-pick some of https://github.com/serokell/nixpkgs/commits/ocaml-cross-fixes

Oh thanks

pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
@yorickvP

This comment has been minimized.

Copy link
Contributor

yorickvP commented Dec 3, 2019

@alexfmpe I was also just told about https://github.com/serokell/tezos-client-packaging, which produces static tezos client binaries

pkgs/top-level/ocaml-packages.nix Outdated Show resolved Hide resolved
alexfmpe and others added 4 commits Dec 19, 2019
Co-Authored-By: Vincent Laporte <vbgl@users.noreply.github.com>
@vbgl
vbgl approved these changes Dec 23, 2019
@vbgl vbgl merged commit c7a9cb0 into NixOS:master Dec 24, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.