Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.conduit: 1.0.0 -> 1.4.0 and dependencies #74821

Merged
merged 4 commits into from Dec 29, 2019

Conversation

@alexfmpe
Copy link
Member

alexfmpe commented Dec 2, 2019

Motivation for this change

https://github.com/mirage/ocaml-conduit/blob/master/CHANGES.md#v140
https://github.com/mirage/ocaml-ipaddr/blob/master/CHANGES.md#v310-2019-03-02

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/development/ocaml-modules/conduit/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/conduit/lwt.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/ipaddr/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/macaddr/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/ipaddr/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/macaddr/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/ipaddr/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/ipaddr/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/conduit/default.nix Outdated Show resolved Hide resolved
@@ -1,20 +1,22 @@
{ stdenv, fetchurl, buildDunePackage, sexplib, ppx_sexp_conv }:
{ stdenv, fetchurl, buildDunePackage, ocaml

This comment has been minimized.

Copy link
@vbgl

vbgl Dec 29, 2019

Contributor

The fetchurl, ocaml and sexplib arguments are not used.

This comment has been minimized.

Copy link
@alexfmpe

alexfmpe Dec 29, 2019

Author Member

Yikes, sorry to force several rounds of this on you. Thanks for staying on top of things.
I just found https://github.com/Synthetica9/nix-linter and used that to find any pesky leftovers.

pkgs/development/ocaml-modules/macaddr/default.nix Outdated Show resolved Hide resolved
@vbgl
vbgl approved these changes Dec 29, 2019
@vbgl

This comment has been minimized.

Copy link
Contributor

vbgl commented Dec 29, 2019

@GrahamcOfBorg build ocamlPackages.cohttp-lwt-unix

@vbgl vbgl merged commit be90b35 into NixOS:master Dec 29, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.cohttp-lwt-unix on aarch64-linux Success
Details
ocamlPackages.cohttp-lwt-unix on x86_64-darwin Success
Details
ocamlPackages.cohttp-lwt-unix on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.