Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] lib/versions: expose splitVersion #74823

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@jonringer
Copy link
Contributor

jonringer commented Dec 2, 2019

Motivation for this change

noticed stable wasn't eval'ing due to this needing to be backported example: #74815

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

(cherry picked from commit fd30529)
@jonringer jonringer requested review from edolstra and nbp as code owners Dec 2, 2019
@jonringer jonringer changed the title lib/versions: expose splitVersion [19.09] lib/versions: expose splitVersion Dec 2, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Dec 2, 2019

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Dec 2, 2019

oh, this isn't able to eval the current release branch, this is awkward.

I might just merge this to fix eval issues

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Dec 2, 2019

The changes are only in lib, this shouldn't cause any rebuilds as it only aides in evaluation, not instantiation.

@jonringer jonringer merged commit 3757f29 into NixOS:release-19.09 Dec 2, 2019
1 check failed
1 check failed
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@jonringer jonringer deleted the jonringer:backport-splitVersion branch Dec 2, 2019
jonringer referenced this pull request Dec 2, 2019
Update latest kernel from 5.3.x to 5.4.x series
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.