Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
plasma5.plasma-workspace: fix patch #74830
At some point a patch accidentally removed
from an if then/while loop in
Which still breaks, but not the way we want...
Motivation for this change
I've been having more problems with KDE lately than normal and while I was going through my journalctl I came across the error message. I'm not sure if it's related to my logout problems or not but... hopefully.
unpackPhase had this source (startkde.cmake)
After the patchPhase
What ends up in bin/startkde
What shellcheck had to say about that (in red, really angry!)
And now, what you've all been waiting for....!
What it looks like with this patch
Which makes shellcheck a bit less angry about that and start mentioning the rest of the file should use globbing and that read without -r mangles backslashes. Whatever that means.
I spent way too long (hours, if not days) trying to figure out how all of this worked... and all just so I could do what ultimately amounts to nothing more than adding two lines to a bash script. Well, not removing two lines from a cmake file. :)
~/projects/nixpkgs tracks NixOS/nixpkgs master, and pr-nixpkgs has this PR... (after unpackPhase and patchPhase)
I don't know that this change would matter; but plasma5 tests still passed.
At some point a patch accidentally removed ``` done break ``` from an if then/while loop in `startkde`. Which still breaks, but not the way we want... plasma-workspace-5.16.5/bin/startkde: line 403: syntax error near unexpected token `fi' plasma-workspace-5.16.5/bin/startkde: line 403: ` fi'
There was a comment in (at least) one of the files that could definitely have been more helpful. I'm not sure if it's entirely inaccurate but it seemed out of date at best and in my case outright misleading. :( The lack of "ensured relevant documentation was up to date" was intentional... I could have probably done a bit more there, but eh, handwaves reasons. >.>