Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compton/picom: 7.2 -> 7.5 #74831

Merged
merged 2 commits into from Jan 3, 2020
Merged

compton/picom: 7.2 -> 7.5 #74831

merged 2 commits into from Jan 3, 2020

Conversation

@adisbladis
Copy link
Member

adisbladis commented Dec 2, 2019

Also change the derivation attribute and name to Picom, a maintained
fork of Compton.

Picom creates compton binaries too, so no config changes required elsewhere.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ertes @Enzime @Twey

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Dec 2, 2019

Commits between 7.2 and 7.5 show that the primary change was the rename, with commits addressing a few memory leaks (and some non-functional cleanup).

Assuming the rename is done right (everything still evals? :P), this seems safe to me :).


Oh, actually:

  • Please rename the directory to reflect the new name (compton -> picom)
  • The NixOS module needs to be updated similarly-- both renaming the file and updating to use pkgs.picom.
  • Please add an alias, so that users of pkgs.compton are warned but not broken.
adisbladis added 2 commits Dec 2, 2019
Also change the derivation attribute and name to Picom, a maintained
fork of Compton.
With a backwards compatibility alias
@adisbladis adisbladis force-pushed the adisbladis:picom-7_5 branch from 34cc444 to aec68f4 Jan 3, 2020
@adisbladis adisbladis requested a review from Infinisil as a code owner Jan 3, 2020
@adisbladis adisbladis merged commit 3dd9020 into NixOS:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.