Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages_latest.phylogenetics: init at unstable-2019-11-15 #74837

Merged
merged 7 commits into from Dec 6, 2019

Conversation

@bcdarwin
Copy link
Contributor

bcdarwin commented Dec 2, 2019

Motivation for this change

Add Biocaml, Gnuplot-Ocaml, and Phylogenetics packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bcdarwin bcdarwin force-pushed the bcdarwin:biocaml branch 2 times, most recently from eb63c7b to f6bc3f5 Dec 2, 2019
@bcdarwin bcdarwin force-pushed the bcdarwin:biocaml branch 2 times, most recently from 094f01b to 0886406 Dec 2, 2019
@bcdarwin bcdarwin force-pushed the bcdarwin:biocaml branch from 0886406 to b8aefbe Dec 3, 2019
@bcdarwin bcdarwin force-pushed the bcdarwin:biocaml branch 2 times, most recently from 6345efc to 275a665 Dec 4, 2019
@@ -291,6 +295,10 @@ let

gmap = callPackage ../development/ocaml-modules/gmap { };

gnuplot = callPackage ../development/ocaml-modules/gnuplot {
inherit (pkgs) gnuplot;

This comment has been minimized.

Copy link
@vbgl

vbgl Dec 6, 2019

Contributor

Please similarly fix the input to metrics-unix. Thanks.

This comment has been minimized.

Copy link
@bcdarwin

bcdarwin Dec 6, 2019

Author Contributor

There's no metrics-unix on this branch; did you mean to comment somewhere else?

This comment has been minimized.

Copy link
@vbgl

vbgl Dec 6, 2019

Contributor

There is one in master. Please rebase and we’ll be good to go.

This comment has been minimized.

Copy link
@bcdarwin

bcdarwin Dec 6, 2019

Author Contributor

Rebase done.

This comment has been minimized.

Copy link
@vbgl

vbgl Dec 6, 2019

Contributor

Cool. Now there is a metrics-unix whose input you can fix.

This comment has been minimized.

Copy link
@bcdarwin

bcdarwin Dec 6, 2019

Author Contributor

I don't understand what you're asking.

Also, what does metrics-unix have to do with this package? Shouldn't that be a separate issue/PR?

This comment has been minimized.

Copy link
@vbgl

vbgl Dec 6, 2019

Contributor

The ocamlPackages.metrics-unix package takes as input gnuplot from the main package set. This PR changes this input: it gives ocamlPackages.gnuplot instead of pkgs.gnuplot.

This comment has been minimized.

Copy link
@bcdarwin

bcdarwin Dec 6, 2019

Author Contributor

Sorry, didn't see that. Done, metrics-unix builds correctly.

@bcdarwin bcdarwin force-pushed the bcdarwin:biocaml branch from 275a665 to 3fa5a19 Dec 6, 2019
@vbgl

This comment has been minimized.

Copy link
Contributor

vbgl commented Dec 6, 2019

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_08.phylogenetics

@vbgl vbgl merged commit 34084d4 into NixOS:master Dec 6, 2019
15 checks passed
15 checks passed
ocaml-ng.ocamlPackages_4_08.phylogenetics on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocaml-ng.ocamlPackages_4_08.phylogenetics on x86_64-darwin Success
Details
ocaml-ng.ocamlPackages_4_08.phylogenetics on x86_64-linux Success
Details
@bcdarwin bcdarwin deleted the bcdarwin:biocaml branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.