Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddy2: init at 2.0.0-beta10 #74843

Merged
merged 2 commits into from Dec 3, 2019
Merged

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Dec 2, 2019

Motivation for this change

https://github.com/caddyserver/caddy/releases/tag/v2.0.0-beta10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/qxym7h0ni197r0aw7ggadd2936c8y6ay-caddy-1.0.3           45.5M
/nix/store/81lga3pi3rl0f80y30a05d28qfh3nysh-caddy-2.0.0-beta10    49.0M
Notify maintainers

cc @rushmorem @fpletz @zimbatm @xfix


This change is Reviewable

@filalex77 filalex77 force-pushed the filalex77:caddy-v2-2.0.0-beta10 branch from 5976343 to 563612d Dec 2, 2019
@filalex77 filalex77 changed the title Caddy v2 2.0.0 beta10 caddy-v2: init at 2.0.0-beta10 Dec 2, 2019
@ofborg ofborg bot requested review from zimbatm, rushmorem, kalbasit and fpletz Dec 2, 2019
pkgs/servers/caddy/default.nix Outdated Show resolved Hide resolved
pkgs/servers/caddy/v2.nix Outdated Show resolved Hide resolved
pkgs/servers/caddy/default.nix Outdated Show resolved Hide resolved
@filalex77 filalex77 force-pushed the filalex77:caddy-v2-2.0.0-beta10 branch from 563612d to 61780e8 Dec 3, 2019
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
Co-Authored-By: Konrad Borowski <konrad@borowski.pw>
@filalex77 filalex77 changed the title caddy-v2: init at 2.0.0-beta10 caddy2: init at 2.0.0-beta10 Dec 3, 2019
@filalex77 filalex77 requested a review from flokli Dec 3, 2019
@xfix
xfix approved these changes Dec 3, 2019
@zimbatm zimbatm merged commit 0ff3121 into NixOS:master Dec 3, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@filalex77 filalex77 deleted the filalex77:caddy-v2-2.0.0-beta10 branch Dec 3, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
Co-Authored-By: Konrad Borowski <konrad@borowski.pw>
(cherry picked from commit 0ff3121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.