Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uw-ttyp0: init at 1.3 #74864

Closed
wants to merge 1 commit into from
Closed

uw-ttyp0: init at 1.3 #74864

wants to merge 1 commit into from

Conversation

@vxid
Copy link

vxid commented Dec 2, 2019

Motivation for this change

Add uw-ttyp0 font to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

So this is the first nixpkg I am submitting, please bear with me.
Tested on my local NixOS installation.

@rnhmjoj

This comment has been minimized.

Copy link
Contributor

rnhmjoj commented Dec 6, 2019

You must have missed my PR #72368. It's basically the same thing with additional generation of .psf fonts and a patch to make the package deterministic.

@vxid

This comment has been minimized.

Copy link
Author

vxid commented Dec 6, 2019

Indeed, I missed your PR. I will close this one.

Quick question though: with pango 1.44 dropping support for type 1 bitmap fonts, shouldn't bitmaps fonts be packaged with an otb version by default?

Some fonts like cherry do it already but I completely forgot about it when opening this PR since 19.09 still uses Pango 1.43.

@rnhmjoj

This comment has been minimized.

Copy link
Contributor

rnhmjoj commented Dec 6, 2019

I didn't know about that, but I don't have any software on my computer using pango.
You should open an issue for this, it seems pretty important.

@rnhmjoj

This comment has been minimized.

Copy link
Contributor

rnhmjoj commented Dec 6, 2019

There is a tool here that does the conversion: https://fedoraproject.org/wiki/BitmapFontConversion

@vxid

This comment has been minimized.

Copy link
Author

vxid commented Dec 6, 2019

Yes, there is also the fonttosnft tool that the cherry font in nixpkgs uses. It's a simple matter of conversion but the results are not always.. accurate. Some fonts are cropped weirdly and the xft naming scheme is not as accurate as the xlfd one.
I will open a separate issue.

@rnhmjoj rnhmjoj mentioned this pull request Dec 7, 2019
18 of 19 tasks complete
@vxid

This comment has been minimized.

Copy link
Author

vxid commented Jan 17, 2020

@vxid vxid closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.