Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackage.progressbar2: Fix #74867

Merged
merged 1 commit into from Dec 7, 2019
Merged

Conversation

@Pamplemousse
Copy link
Member

Pamplemousse commented Dec 2, 2019

Motivation for this change

progressbar2 build fails on my machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ashgillman

The `postPatch` phase is failing when no `.pyc` file is generated in
`tests` by the build (`rm: missing operand` error).

As per @jonringer's comment, the whole `postPatch` is not needed anymore.
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:fix_progressbar2 branch from a601dac to ec1a445 Dec 3, 2019
Copy link
Contributor

jonringer left a comment

LGTM

baseline failures are from gym being broken on master

[4 built (3 failed), 45 copied (774.7 MiB), 513.1 MiB DL]
error: build of '/nix/store/2cbbbcz2q03qv9fljjh8h41lblrj1qvm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74867
1 package are marked as broken and were skipped:
python27Packages.baselines

2 package failed to build:
python37Packages.baselines python38Packages.baselines

4 package were built:
python27Packages.progressbar2 python37Packages.progressbar2 python38Packages.progressbar2 truvari
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Dec 3, 2019

@GrahamcOfBorg build python27Packages.progressbar2 python37Packages.progressbar2 python38Packages.progressbar2 truvari

@marsam marsam merged commit 0b2d9ab into NixOS:master Dec 7, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.progressbar2, python37Packages.progressbar2, python38Packages.progressbar2, truvari on aarch64-linux Success
Details
python27Packages.progressbar2, python37Packages.progressbar2, python38Packages.progressbar2, truvari on x86_64-darwin Success
Details
python27Packages.progressbar2, python37Packages.progressbar2, python38Packages.progressbar2, truvari on x86_64-linux Success
Details
@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Dec 7, 2019

Thank you @Pamplemousse

@Pamplemousse Pamplemousse deleted the Pamplemousse:fix_progressbar2 branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.