Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.sbv: remove from list of broken packages #74870

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@h-jones-uk
Copy link

h-jones-uk commented Dec 2, 2019

Motivation for this change

sbv-8.3 is marked as broken, but it builds successfully and works on x86_64-linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cdepillabout

This comment has been minimized.

Copy link
Member

cdepillabout commented Dec 3, 2019

This LGTM. I've tested that it can be built on my machine.

@cdepillabout cdepillabout merged commit d7d9926 into NixOS:haskell-updates Dec 3, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.