Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

djvulibre: patching multiple CVEs #74875

Closed
wants to merge 1 commit into from

Conversation

@d-goldin
Copy link
Contributor

d-goldin commented Dec 3, 2019

Motivation for this change

Addresses:

#73624
#70086

19.09: #74876
19.03: #74877

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ckauhaus @Anton-Latukha

Addresses:

#73624
#70086
@d-goldin d-goldin force-pushed the d-goldin:djvulibre_sec_patches branch from 721f0ae to be7e51a Dec 3, 2019
@ofborg ofborg bot requested a review from Anton-Latukha Dec 3, 2019
@ckauhaus

This comment has been minimized.

Copy link
Contributor

ckauhaus commented Dec 3, 2019

So many locally added patches... is there a way to use fetchpatch from online resources? /me in the fear of nixpkgs tree bloat...

@d-goldin

This comment has been minimized.

Copy link
Contributor Author

d-goldin commented Dec 3, 2019

@ckauhaus: I would have preferred that too, but with sourceforge I did not see a way to do that. But I can check again.

@d-goldin

This comment has been minimized.

Copy link
Contributor Author

d-goldin commented Dec 3, 2019

There might be also some other issues with this. I ran a nix-review build on the 19.09 PR:

[16/444/549 built (4 failed), 2913 copied (19276.7/19287.7 MiB), 7082.3 MiB DL] building birdfont-2.27.0 (buildPhase): build/libbirdfont/PenTool.c: In function �cannot build derivation '/nix/store/4jf3qxpwn5qnkf8dwhca2x3mrq5b96zm-env.drv': 4 dependencies couldn't be built
[548 built (4 failed), 2913 copied (19276.7 MiB), 7082.3 MiB DL]
error: build of '/nix/store/4jf3qxpwn5qnkf8dwhca2x3mrq5b96zm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74876
4 package failed to build:
gscan2pdf k3d octaveHg winswitch

k3d, octaveHg and winswitch are unrelated, but gscan2pdf seems to be related.
So I'll briefly look into that.

@d-goldin

This comment has been minimized.

Copy link
Contributor Author

d-goldin commented Dec 3, 2019

Alright, seems like gscan2pdf is fine, just that the test-suite is a bit load/timing sensitive and with high system load during nix-review not enough iterations of some tests could happen within desired timespan.

@ckauhaus

This comment has been minimized.

Copy link
Contributor

ckauhaus commented Dec 4, 2019

  • Confirm djvulibre build on NixOS and Darwin
  • Confirm gscan2pdf build on NixOS
@ckauhaus

This comment has been minimized.

Copy link
Contributor

ckauhaus commented Dec 4, 2019

Confirm gscan2pdf build on NixOS and Darwin

@ckauhaus

This comment has been minimized.

Copy link
Contributor

ckauhaus commented Dec 4, 2019

@d-goldin Merged to staging, but GitHub didn't recognise the fact for some reason. This branch can be deleted.

@ckauhaus ckauhaus closed this Dec 4, 2019
@d-goldin d-goldin deleted the d-goldin:djvulibre_sec_patches branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.