Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upawscli: remove unnecessary override on python prompt_toolkit #74891
+0
−2
Conversation
This comment has been minimized.
This comment has been minimized.
Note that this does not change the hash of the package:
so it should just be a no-op cleanup of an unnecessary override. CC @jonringer @FRidh |
This override to the old 1.x version of `prompt_toolkit` appears to be unnecessary; removing it does not change the hash of `awscli`. In a follow-up, we could likely remove the RSA override as well, if we're OK with patching out the `setup.cfg` requirements. This dropped support for some old modules, but appears to not break API compatibility otherwise: https://github.com/sybrenstuvel/python-rsa/blob/master/CHANGELOG.md#version-40---released-2018-09-16
bc792c3
to
89be83c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bhipple commentedDec 3, 2019
This override to the old 1.x version of
prompt_toolkit
appears to beunnecessary; removing it does not change the hash of
awscli
.In a follow-up, we could likely remove the RSA override as well, if we're OK
with patching out the
setup.cfg
requirements. This dropped support for someold modules, but appears to not break API compatibility otherwise:
https://github.com/sybrenstuvel/python-rsa/blob/master/CHANGELOG.md#version-40---released-2018-09-16
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @muflax