Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gebaar-libinput: init at 0.0.5 #74896

Open
wants to merge 1 commit into
base: master
from

Conversation

@lovesegfault
Copy link
Contributor

lovesegfault commented Dec 3, 2019

Motivation for this change

Wasn't packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @colemickens @andir

@lovesegfault lovesegfault force-pushed the lovesegfault:geebar-libinput branch from 5074406 to 7ecef44 Dec 3, 2019
@lovesegfault

This comment has been minimized.

Copy link
Contributor Author

lovesegfault commented Dec 3, 2019

All fixed, thanks @jtojnar!

@lovesegfault

This comment has been minimized.

Copy link
Contributor Author

lovesegfault commented Dec 5, 2019

is this ready @jtojnar @colemickens?

@@ -0,0 +1,29 @@
{ gcc8Stdenv, fetchFromGitHub

This comment has been minimized.

Copy link
@doronbehar

doronbehar Dec 6, 2019

Contributor

Usually, we import in the default.nix file stdenv and then callPackage with stdenv = gcc8Stdenv.

@@ -2417,6 +2417,8 @@ in

evdevremapkeys = callPackage ../tools/inputmethods/evdevremapkeys { };

geebar-libinput = callPackage ../tools/inputmethods/gebaar-libinput { };

This comment has been minimized.

Copy link
@doronbehar

doronbehar Dec 6, 2019

Contributor

See my previous comment

Suggested change
geebar-libinput = callPackage ../tools/inputmethods/gebaar-libinput { };
geebar-libinput = callPackage ../tools/inputmethods/gebaar-libinput {
stdenv = gcc8Stdenv;
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.