Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upower: load config from /etc #74903

Closed
wants to merge 2 commits into from

Conversation

@mat8913
Copy link
Contributor

mat8913 commented Dec 3, 2019

Motivation for this change

In the process of making UPower.conf customizable (#73968), it came up that UPower doesn't load its config from /etc by default.

Things done

The UPower derivation is modified to make it load its config from /etc at runtime, but still install the default config to its nix store path as before.

The UPower module is modified to symlink the default config into /etc.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

In the process of making UPower.conf customizable (#73968), it came up
that UPower doesn't load its config from /etc by default.

The UPower derivation is modified to make it load its config from /etc
at runtime, but still install the default config to its nix store path
as before.

The UPower module is modified to symlink the default config into /etc.
@jtojnar
jtojnar approved these changes Dec 3, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 3, 2019

LGTM with @jtojnar suggestion.

Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
@mat8913 mat8913 closed this Dec 4, 2019
@mat8913 mat8913 deleted the mat8913:upower-etc branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.