Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: 70.0.1 -> 71.0 #74905

Merged
merged 6 commits into from Dec 5, 2019

Conversation

@andir
Copy link
Member

andir commented Dec 3, 2019

Motivation for this change

This updates Firefox to the upcoming stable version.

This might look like it should go to staging but it actually just has to land on master AFTER #74795 since that already includes the NSS bump. I kept it in this branch to have a consistent history regarding what kind of updates are required to make this work.

Release notes should pop up at https://www.mozilla.org/en-US/firefox/71.0/releasenotes/ some time today/tomorrow.

I'll start working on a backport of all the deps to stable within the next day.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@andir andir requested a review from taku0 Dec 3, 2019
andir added 3 commits Dec 3, 2019
@taku0

This comment has been minimized.

Copy link
Contributor

taku0 commented Dec 3, 2019

@andir could you also update firefox-esr? If so, I will close #74907 as a duplication.

@andir

This comment has been minimized.

Copy link
Member Author

andir commented Dec 3, 2019

@andir could you also update firefox-esr? If so, I will close #74907 as a duplication.

Yes, will do. Will push once the build succeeds.

@taku0
taku0 approved these changes Dec 3, 2019
Copy link
Contributor

taku0 left a comment

Other than lib.versionOlder ffversion "68.2.0", LGTM and succeeded to build and run.

@andir andir force-pushed the andir:firefox-71 branch from 50972f9 to 1993a8b Dec 3, 2019
@mweinelt

This comment has been minimized.

Copy link
Contributor

mweinelt commented Dec 3, 2019

Tested with nix-review and run for an hour without issues.

@edolstra

This comment has been minimized.

Copy link
Member

edolstra commented Dec 3, 2019

Can you check if it builds with Rust 1.39? Currently we have a line inherit (rustPackages_1_38_0) cargo rustc; in firefoxPackages which would be nice to get rid of.

@andir

This comment has been minimized.

Copy link
Member Author

andir commented Dec 3, 2019

Can you check if it builds with Rust 1.39? Currently we have a line inherit (rustPackages_1_38_0) cargo rustc; in firefoxPackages which would be nice to get rid of.

Firefox will probably work (at least 71.x) but the tor browser will not work just yet.

I am planning on reworking the way we are currently passing packages into this as it isn't very flexible enough for the variants of packages we are building with firefoxPackages.

@andir andir mentioned this pull request Dec 5, 2019
0 of 10 tasks complete
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Dec 5, 2019

staging-next got merged.

@andir andir merged commit 8465cae into NixOS:master Dec 5, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nss on aarch64-linux Success
Details
nss on x86_64-darwin Success
Details
nss on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.