Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot: 3.1.1 -> 3.1.2 #74906

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@Moredread
Copy link
Contributor

Moredread commented Dec 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Dec 3, 2019

cc @Twey

@davidak

This comment has been minimized.

Copy link
Member

davidak commented Dec 4, 2019

Build fails for me. Can you check the hash?

[davidak@ethmoid:~/code/nixpkgs]$ nix-shell -p nix-review --run "nix-review pr 74906"
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/74906/head:refs/nix-review/1
remote: Enumerating objects: 378, done.
remote: Counting objects: 100% (378/378), done.
remote: Compressing objects: 100% (23/23), done.
remote: Total 563 (delta 367), reused 356 (delta 355), pack-reused 185
Receiving objects: 100% (563/563), 504.74 KiB | 1.22 MiB/s, done.
Resolving deltas: 100% (414/414), completed with 188 local objects.
From https://github.com/NixOS/nixpkgs
 + 84586a4514d...bcfa14af154 master               -> refs/nix-review/0  (forced update)
 + 240f189d03a...091226bef0a refs/pull/74906/head -> refs/nix-review/1  (forced update)
$ git worktree add /home/davidak/.cache/nix-review/pr-74906/nixpkgs bcfa14af1544367bbb2245fc639b470124514385
Preparing worktree (detached HEAD bcfa14af154)
Updating files: 100% (20404/20404), done.
HEAD is now at bcfa14af154 terraform-providers: bump version (#74991)
$ git merge --no-commit 091226bef0ab31a102496350f7a642fedea67379
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/davidak/.cache/nix-review/pr-74906/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
hash mismatch in fixed-output derivation '/nix/store/qz0yias0gb0gchbcfb3fppckyr7psa21-source':
  wanted: sha256:0wnjvxn3pim1fp31f70m2fmxr0v7zqlg3vcv8dfmvphpm73wqv28
  got:    sha256:12305wj2i4067jc50l8r0wmb7zjcna24fli8vb8kiaild0jrlip6
cannot build derivation '/nix/store/q0mfn2zi6xc35yasa93kmmn9sz5wncym-godot-3.1.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vvag0ii2cqk4n46675cclsz8lbnmszn2-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 7 copied (10.0 MiB), 1.8 MiB DL]
error: build of '/nix/store/vvag0ii2cqk4n46675cclsz8lbnmszn2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74906
1 package failed to build:
godot
@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Dec 4, 2019

Looks like they retagged the release: Note: The git tag was redone to include two hotfixes for the HTML5 platform. Other platforms are not impacted.

I update the hash.

@Moredread Moredread force-pushed the Moredread:godot branch from 091226b to e2d24a0 Dec 4, 2019
@davidak
davidak approved these changes Dec 5, 2019
Copy link
Member

davidak left a comment

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
Possible improvements
Comments

Thanks for your contribution!

@nlewo nlewo merged commit 2e0646e into NixOS:master Dec 6, 2019
15 checks passed
15 checks passed
godot on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
godot on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Moredread Moredread deleted the Moredread:godot branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.