Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeval: 0.7.3 -> 0.14.0 #74908

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@groodt
Copy link
Contributor

groodt commented Dec 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nicknovitski

@groodt groodt force-pushed the groodt:kubeval-0.14.0 branch 2 times, most recently from 725157e to 9d05744 Dec 3, 2019
@groodt groodt requested review from basvandijk and cdepillabout as code owners Dec 3, 2019
@groodt groodt force-pushed the groodt:kubeval-0.14.0 branch from 9d05744 to 58476ac Dec 3, 2019
@ofborg ofborg bot added the 6.topic: haskell label Dec 3, 2019
@ofborg ofborg bot requested a review from kalbasit Dec 3, 2019
@filalex77

This comment has been minimized.

Copy link
Contributor

filalex77 commented Dec 3, 2019

Testing build on darwin
@GrahamcOfBorg build kubeval

@groodt

This comment has been minimized.

Copy link
Contributor Author

groodt commented Dec 3, 2019

@filalex77 I don't suppose you're able to look into this one too? #73093

It's been sitting for a while...

@filalex77

This comment has been minimized.

Copy link
Contributor

filalex77 commented Dec 4, 2019

Sorry @groodt, but I also don't have merge rights yet :(

I'll ping some maintainers I know to see if we can resolve this and #73093 faster. To said maintainers: sorry if that's not the way to do it.

cc @jonringer @worldofpeace @marsam @Ma27

Copy link
Contributor

filalex77 left a comment

Works for me on NixOS unstable. (checked with nix-review)

@marsam marsam merged commit 591aee2 into NixOS:master Dec 4, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kubeval on aarch64-linux Success
Details
kubeval on x86_64-darwin Success
Details
kubeval on x86_64-linux Success
Details
@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Dec 4, 2019

Thank you @groodt, please feel free to ping me if a PR gets stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.