Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectacle: add new kwayland dependency #74910

Conversation

@ajs124
Copy link
Member

ajs124 commented Dec 3, 2019

Motivation for this change

Fix the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

@schmittlauch

This comment has been minimized.

Copy link
Contributor

schmittlauch commented Dec 3, 2019

Edit: Nevermind, I forgot how the KDE packaging in nixpkgs specifies the source and version number outside of the main derivation file.
So fixing it like this is fine.


Any ideas why this suddenly broke? The last commit for that derivation on release-19.09 is from May 28. So probably a version bump of some dependency broke the build.
It might be a cleaner solution to add kwayland to the propagatedBuildInputs of the dependency causing the breakage.

@schmittlauch

This comment has been minimized.

Copy link
Contributor

schmittlauch commented Dec 3, 2019

Apart from that I just nix-reviewed this PR and can confirm it to build and run properly.

@ajs124

This comment has been minimized.

Copy link
Member Author

ajs124 commented Dec 3, 2019

I honestly didn't think much about these two lines of diff, @nyanloutre committed it to master like this, so I just backported it.

@adisbladis adisbladis merged commit 461d5db into NixOS:release-19.09 Dec 3, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
spectacle on aarch64-linux Success
Details
spectacle on x86_64-linux Success
Details
@ajs124 ajs124 deleted the helsinki-systems:backport/spectacle_wayland_fix branch Dec 3, 2019
@jamescostian

This comment has been minimized.

Copy link

jamescostian commented Dec 3, 2019

Hi, this is not working for me on 19.09. I tried nixos-rebuild switch and nixos-rebuild switch --upgrade but neither worked. Am I doing something wrong?

@ajs124

This comment has been minimized.

Copy link
Member Author

ajs124 commented Dec 3, 2019

The channel hasn't advanced yet, since this was merged.

Just wait a bit and try again.

@adisbladis

This comment has been minimized.

Copy link
Member

adisbladis commented Dec 3, 2019

You chan check https://howoldis.herokuapp.com for channel progression status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.