Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver: 76.0.3809.68 -> 78.0.3904.105 #74946

Merged
merged 1 commit into from Dec 4, 2019
Merged

chromedriver: 76.0.3809.68 -> 78.0.3904.105 #74946

merged 1 commit into from Dec 4, 2019

Conversation

cardenaso11
Copy link

@cardenaso11 cardenaso11 commented Dec 3, 2019 •
edited

Motivation for this change

This makes it match the chromium version in nixpkgs 19.09, chromium 78

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer

@cardenaso11 cardenaso11 changed the title Bump chromedriver to chrome 78 chromedriver: 76.0.3809.68 -> 78.0.3904.105 Dec 3, 2019
@ofborg ofborg bot requested a review from cillianderoiste December 3, 2019 22:55
@marsam marsam merged commit 093faad into NixOS:release-19.09 Dec 4, 2019
@marsam
Copy link
Contributor

marsam commented Dec 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cardenaso11 @marsam @Janik-Haag