Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exult: 1.4.9rc1 -> 1.5.0git #74962

Closed
wants to merge 1 commit into from
Closed

Conversation

@fitzgibbon
Copy link

@fitzgibbon fitzgibbon commented Dec 4, 2019

Motivation for this change

The previous version, 1.4.9rc1 would not run for me after a fresh install. Since the tarball for that was the latest version available on SourceForge, I switched to using the GitHub sources at the current latest commit. This removes the need for the arch patches too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

};

configureFlags = [ "--disable-tools" ];
preConfigure = "./autogen.sh";

This comment has been minimized.

@doronbehar

doronbehar Mar 4, 2020
Contributor

Add autoreconfHook (instead of automake and autoconf and libtool) to nativeBuildInputs.

@@ -12,35 +12,30 @@ let
in

stdenv.mkDerivation rec {
name = "exult-1.4.9rc1";
name = "exult-1.5.0git";

This comment has been minimized.

@doronbehar

doronbehar Mar 4, 2020
Contributor

Switch to pname and version.

src = fetchFromGitHub {
owner = "exult";
repo = "exult";
rev = "b727abfffc08a54e528bc1194d0de8562d18d74e";

This comment has been minimized.

@doronbehar

doronbehar Mar 4, 2020
Contributor

So what's up with their releases names: https://github.com/exult/exult/releases ?

It seems to me they use the releases names to imply what major changes were done in that release. Hence, I'd switch to a date based version = and download whatever they count as a release.

[ # Arch Linux patch set.
./arch.patch
];
configureFlags = [ "--disable-tools" ];

This comment has been minimized.

@doronbehar

doronbehar Mar 4, 2020
Contributor

This seems like an interesting feature. Could you perhaps add a enableTools to the derivation's arguments and use lib.optionals here?

@mausch
Copy link

@mausch mausch commented Sep 5, 2020

I think this has been superseded by #89364 now, it can be closed.

@fitzgibbon fitzgibbon closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.