Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sweet: init at 1.10.5 #74966

Merged
merged 2 commits into from Dec 11, 2019
Merged

sweet: init at 1.10.5 #74966

merged 2 commits into from Dec 11, 2019

Conversation

@Fuzen-py
Copy link
Contributor

@Fuzen-py Fuzen-py commented Dec 4, 2019

Motivation for this change

Sweet theme is a popular theme on r/unixporn, so I added created a package for it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 10, 2019

just curious, how is this susposed to be tested?

@Fuzen-py
Copy link
Contributor Author

@Fuzen-py Fuzen-py commented Dec 10, 2019

I'm not sure how the testing processes for GTK themes works I am rather new to NixOS, I just installed the package and checked if the theme worked. I checked the manual for this and the wiki, but didn't see anything about testing themes.

@Fuzen-py Fuzen-py requested a review from jonringer Dec 10, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 11, 2019

@worldofpeace are you familiar with themes?

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 11, 2019

@worldofpeace are you familiar with themes?

Absolutely familiar 👍 .

You can test this by installing it into your nix-profile, themes are loaded from XDG_DATA_DIRS.
If someone prefers to not modify their system state they could do

GTK_THEME=$theme_name XDG_DATA_DIRS="$XDG_DATA_DIRS:$nix_store_path_to_theme/share" $some_gtk_program
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 11, 2019

I've tested like

XDG_DATA_DIRS="$XDG_DATA_DIRS:$(nix-build -A sweet)/share" "$(nix-build -A gtk3.dev)/bin/gtk3-widget-factory"

and Ctrl+Shift+d -> Debugger Window -> Visual -> GTK Theme

@worldofpeace worldofpeace changed the title sweet init at 1.10.5 sweet: init at 1.10.5 Dec 11, 2019
@worldofpeace worldofpeace merged commit e96c903 into NixOS:master Dec 11, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sweet on aarch64-linux Success
Details
sweet on x86_64-linux Success
Details
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 11, 2019

Thanks @Fuzen-py 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.