Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racket: 7.4 -> 7.5 #74968

Merged
merged 1 commit into from Dec 5, 2019
Merged

racket: 7.4 -> 7.5 #74968

merged 1 commit into from Dec 5, 2019

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Dec 4, 2019

Motivation for this change

Release Announcement: https://download.racket-lang.org/v7.5.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@davidak
davidak approved these changes Dec 4, 2019
Copy link
Member

@davidak davidak left a comment

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • all depending packages build
Possible improvements
Comments

Thanks for your contribution!

I have tested this binaries:

racket: racket, drracket
racket-minimal: racket, raco

cc maintainers @henrytill @vrthra

Copy link
Member

@davidak davidak left a comment

From your release link:

Almost all of Racket version 7.5 is distributed under a new,
less-restrictive license: either the Apache 2.0 license or the MIT
license. See https://blog.racket-lang.org/2019/11/completing-racket-s-relicensing-effort.html
for more details.

Please change the license to MIT and Apache2!

Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

What @davidak said, besides that - LGTM.

@marsam marsam force-pushed the marsam:update-racket branch from dd932d6 to afcf6d2 Dec 5, 2019
@marsam
Copy link
Contributor Author

@marsam marsam commented Dec 5, 2019

@davidak good catch, I've updated the licence field. Thanks!

@marsam marsam merged commit f00e169 into NixOS:master Dec 5, 2019
15 checks passed
15 checks passed
racket on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
racket on x86_64-linux Success
Details
@marsam marsam deleted the marsam:update-racket branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.