Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: init nidaqmx #74980

Closed
wants to merge 1 commit into from
Closed

WIP: init nidaqmx #74980

wants to merge 1 commit into from

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Dec 4, 2019

This commit adds the NI-DAQmx software for data-acquisition with NI hardware.

The nidaqmxbase package is small, however, provides functionality only for a limited set of hardware.

The nidaqmx package on the other hand supports (nearly) all hardware. Packages are provided however
only for Windows and CentOS. The RPM repo data is used to generate a package set.

TODO:

  • split nidaqmx, nixdaqmxbase and nidaqmx-python in separate commits
  • nidaqmx-python should optionally work with nidaqmx and/or nidaqmxbase
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@@ -0,0 +1,392 @@
/nix/store/6j558vkwvk1a15ihgglniiwxwjfwj5mh-libiotracelog-foo/lib/x86_64-linux-gnu/ni-iotrace/lib64/libNiSpyLog.so.18.1.0

This comment has been minimized.

@FRidh

FRidh Dec 4, 2019
Author Member

This file will be removed..

repo = lib.importJSON ./repo.json;

# Add symbolic links to versioned .so files.
addSharedObjectVersioningLinksHook = writeShellScript "add-shared-object-versioning-links" ''

This comment has been minimized.

@FRidh

FRidh Dec 4, 2019
Author Member

Not needed anymore

@FRidh FRidh force-pushed the FRidh:nidaqmx branch 2 times, most recently from 889d3f9 to 57be0e6 Dec 5, 2019
This commit adds the NI-DAQmx software for data-acquisition with NI hardware.

The nidaqmxbase package is small, however, provides functionality only for a limited set of hardware.

The nidaqmx package on the other hand supports (nearly) all hardware. Packages are provided however
only for Windows and CentOS. The RPM repo data is used to generate a package set.

TODO:
- [ ] split nidaqmx, nixdaqmxbase and nidaqmx-python in separate commits
- [ ] nidaqmx-python should optionally work with nidaqmx and/or nidaqmxbase
- [ ] fix kernel/dkms packages. Probably need to set KBUILD_EXTRA_SYMBOLS
- [ ] provide nixos module and mapping modules/packages
@stale
Copy link

@stale stale bot commented Aug 3, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Aug 3, 2020
@FRidh FRidh closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.