Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sundials: 4.1.0 -> 5.0.0 #74988

Merged
merged 1 commit into from Dec 6, 2019
Merged

sundials: 4.1.0 -> 5.0.0 #74988

merged 1 commit into from Dec 6, 2019

Conversation

@smaret
Copy link
Contributor

@smaret smaret commented Dec 4, 2019

Motivation for this change

Update sundials to the latest upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @idontgetoutmuch

@smaret
Copy link
Contributor Author

@smaret smaret commented Dec 4, 2019

nix-review pr succeeds on both macOS and Debian.

@flokli
Copy link
Contributor

@flokli flokli commented Dec 4, 2019

scikits-odes 2.5.0 was released, which should work with sundials 4.1.

There were plans on removing pkgs/development/libraries/sundials/3.x.nix, meaning this would bump sundials for scikits-odes, too.
@idontgetoutmuch did you check if scikits-odes builds with sundials 5.x, too?

@flokli
Copy link
Contributor

@flokli flokli commented Dec 6, 2019

Anyways, this shouldn't block this PR.

@flokli
Copy link
Contributor

@flokli flokli commented Dec 6, 2019

@GrahamcOfBorg build sundials

@flokli flokli merged commit d3ee140 into NixOS:master Dec 6, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sundials on aarch64-linux Success
Details
sundials on x86_64-darwin Success
Details
sundials on x86_64-linux Success
Details
@smaret smaret deleted the smaret:sundials-5.0.0 branch Dec 6, 2019
@idontgetoutmuch
Copy link
Member

@idontgetoutmuch idontgetoutmuch commented Dec 14, 2019

scikits-odes 2.5.0 was released, which should work with sundials 4.1.

There were plans on removing pkgs/development/libraries/sundials/3.x.nix, meaning this would bump sundials for scikits-odes, too.
@idontgetoutmuch did you check if scikits-odes builds with sundials 5.x, too?

Yes it builds but they seem to have released

https://computing.llnl.gov/projects/sundials/download/sundials-5.0.0-dev.2.tar.gz
https://computing.llnl.gov/projects/sundials/download/sundials-5.0.0-dev.1.tar.gz
https://computing.llnl.gov/projects/sundials/download/sundials-5.0.0-dev.0.tar.gz

I validated dev.2. I can submit a PR to nixpkgs for sundials but should we wait until they release a final version? TBH it's not much work so I'll submit a PR which can be rejected if people want to wait.

@idontgetoutmuch
Copy link
Member

@idontgetoutmuch idontgetoutmuch commented Dec 14, 2019

Oh my bad - let me check the non-dev version.

@idontgetoutmuch
Copy link
Member

@idontgetoutmuch idontgetoutmuch commented Dec 14, 2019

That works but you already knew that ;-)

@idontgetoutmuch
Copy link
Member

@idontgetoutmuch idontgetoutmuch commented Dec 15, 2019

scikits-odes 2.5.0 was released, which should work with sundials 4.1.

There were plans on removing pkgs/development/libraries/sundials/3.x.nix, meaning this would bump sundials for scikits-odes, too.
@idontgetoutmuch did you check if scikits-odes builds with sundials 5.x, too?

It does not build with sundials 5.0 - the maintainer(s) of scikits-odes will need to do something as the directory structure / naming conventions have changed. See bmcage/odes#98 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.