Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez: 5.50 -> 5.52 #74995

Merged
merged 2 commits into from Dec 9, 2019
Merged

bluez: 5.50 -> 5.52 #74995

merged 2 commits into from Dec 9, 2019

Conversation

@Moredread
Copy link
Contributor

@Moredread Moredread commented Dec 4, 2019

Motivation for this change

Replaces PR #69460

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify previous commenters

cc @bkchr @mweinelt @jonringer @jtojnar @adisbladis

@Moredread
Copy link
Contributor Author

@Moredread Moredread commented Dec 4, 2019

@mweinelt I disabled doCheck again, I saw the midi and another test fail on a Windows WSL install, each in seperate runs. On my NixOS machine though all run fine. I think we should investigate this issue separately.

@Moredread Moredread changed the base branch from master to staging Dec 4, 2019
@Moredread Moredread changed the base branch from staging to master Dec 4, 2019
@Moredread
Copy link
Contributor Author

@Moredread Moredread commented Dec 4, 2019

@GrahamcOfBorg build bluez

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 4, 2019

Tested with Logitech MX Ergo and Sony WH-1000XM3 and working great. Thanks alot for taking care of this!

pkgs/os-specific/linux/bluez/default.nix Show resolved Hide resolved
pkgs/os-specific/linux/bluez/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/bluez/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/bluez/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@Moredread Moredread force-pushed the Moredread:bluez branch 2 times, most recently from ebf46eb to fafa0c1 Dec 4, 2019
@jtojnar
jtojnar approved these changes Dec 4, 2019
@FRidh FRidh added this to Needs review in Staging Dec 5, 2019
bkchr and others added 2 commits Sep 26, 2019
Also add new configuration flag options and enable them for the bluezFull package by default.
@Moredread Moredread force-pushed the Moredread:bluez branch from cfc2e4f to 83655d6 Dec 8, 2019
@Moredread Moredread requested a review from worldofpeace Dec 8, 2019
@Moredread
Copy link
Contributor Author

@Moredread Moredread commented Dec 8, 2019

@GrahamcOfBorg build bluez

Staging automation moved this from Needs review to Ready Dec 9, 2019
Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM 👍

@worldofpeace worldofpeace merged commit a83fa64 into NixOS:staging Dec 9, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bluez on aarch64-linux Success
Details
bluez on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Ready to Done Dec 9, 2019
@worldofpeace worldofpeace mentioned this pull request Dec 9, 2019
3 of 10 tasks complete
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 9, 2019

I've built #75317, with checks on NixOS three times in succession without any test failure.

@Moredread Moredread deleted the Moredread:bluez branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.