Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vulgarity from wordpress nixos module #74996

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@jsamsa
Copy link
Contributor

@jsamsa jsamsa commented Dec 4, 2019

Motivation for this change

remove unnecessary vulgarity that would show up in nixos options. Useful for those of us who would like to promote nixos in our organizations.

Things done

edited comment

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@grahamc
Copy link
Member

@grahamc grahamc commented Dec 4, 2019

Thank you.

@grahamc grahamc merged commit 458b84d into NixOS:master Dec 4, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Cloning project
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.