Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gertty: init at 1.6.0 #74998

Open
wants to merge 1 commit into
base: master
from
Open

gertty: init at 1.6.0 #74998

wants to merge 1 commit into from

Conversation

@Dav1d23
Copy link

@Dav1d23 Dav1d23 commented Dec 4, 2019

Motivation for this change

Add gertty package to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

@knedlsepp knedlsepp left a comment

Congratulations on your first PR in nixpkgs! 👍
There's some minor ways on improving this derivation still. A lot of the information on that you can find in https://nixos.org/nixpkgs/manual/#reference I did try to point to the sections that contain the relevant information.

pkgs/development/tools/gertty/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gertty/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gertty/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gertty/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gertty/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gertty/default.nix Outdated Show resolved Hide resolved
@Dav1d23 Dav1d23 force-pushed the Dav1d23:master branch from 7157ac3 to 1b33b17 Mar 15, 2020
@Dav1d23 Dav1d23 requested review from FRidh and jonringer as code owners Mar 15, 2020
@ofborg ofborg bot added the 6.topic: python label Mar 15, 2020
@Dav1d23 Dav1d23 requested a review from knedlsepp Mar 15, 2020
Copy link
Contributor

@jonringer jonringer left a comment

dav1d23 = {
email = "petrodavi@gmail.com";
github = "dav1d23";
githubId = 10028479;
name = "David Petroni";
};
Comment on lines +1670 to +1675

This comment has been minimized.

@jonringer

jonringer Mar 15, 2020
Contributor

this should be a separate commit:

maitainers: add dav2d23
@stale
Copy link

@stale stale bot commented Sep 11, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.