Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtspim: init at 722 #74999

Open
wants to merge 1 commit into
base: master
from
Open

qtspim: init at 722 #74999

wants to merge 1 commit into from

Conversation

@aske
Copy link
Member

@aske aske commented Dec 4, 2019

Motivation for this change

Add a MIPS32 simulator.

To build a documentation I've needed to set QT_QPA_PLATFORM_PATH and QT_PLUGIN_PATH because qhelpgenerator failed with:

qt.qpa.plugin: Could not find the Qt platform plugin "minimal" in ""

Either way after installation I did not manage to make qtspim find its help file, so I added a patch disabling doc building to save some build time.

@ttuegel maybe you have ideas on what's going on?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @


buildInputs = [ qtbase qttools ];

# Remove build artefacts from the repo

This comment has been minimized.

@langston-barrett

langston-barrett Dec 4, 2019
Contributor

Suggested change
# Remove build artefacts from the repo
# Remove build artifacts from the repo

This comment has been minimized.

@aske

aske Dec 5, 2019
Author Member

Fixed, thanks!

@aske aske force-pushed the aske:spim branch from c86c8da to 2e0e1b0 Dec 5, 2019
install -D ../Documentation/qtspim.man $out/usr/share/man/man1/qtspim.1
gzip -f --best $out/usr/share/man/man1/qtspim.1
install -d $out/usr/share/qtspim

This comment has been minimized.

@ttuegel

ttuegel Dec 8, 2019
Member

All of these paths should be $out/share/... (no /usr prefix). This may affect finding the files at runtime.

This comment has been minimized.

@aske

aske Dec 8, 2019
Author Member

Thanks, fixed!

Finally found what's up with the docs -- doesn't have anything to do with Qt, just a bunch of hardcoded paths in the source code (missed initially them while stracing as qtspim accessed them, while I expected other syscalls).

@aske aske force-pushed the aske:spim branch 3 times, most recently from 601f767 to 2cc7fba Dec 8, 2019
buildPhase = ''
export QT_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}"
export QT_QPA_PLATFORM_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}/platforms"
make

This comment has been minimized.

@aske

aske Dec 8, 2019
Author Member

@ttuegel is there a better way to make qhelpgenerator inside build work than setting these vars?

This comment has been minimized.

@aske

aske Dec 8, 2019
Author Member

(about "Outdated") moved it to preBuild, question is still valid

This comment has been minimized.

@aske

aske Dec 8, 2019
Author Member

(moved it to the buildPhase again, as preBuild version sometimes broke down when building with more than 3 --cores)

This comment has been minimized.

@ttuegel

ttuegel Jul 20, 2020
Member

I'm not sure why setting QT_PLUGIN_PATH isn't sufficient, and it should be OK to set these in preBuild, but I don't see anything wrong with this.

@ofborg ofborg bot removed the 8.has: documentation label Dec 8, 2019
@aske aske force-pushed the aske:spim branch 2 times, most recently from da9c842 to 047a586 Dec 8, 2019
@aske aske force-pushed the aske:spim branch from 047a586 to 9a2f52e Dec 8, 2019
@stale
Copy link

@stale stale bot commented Jun 5, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 5, 2020
buildPhase = ''
export QT_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}"
export QT_QPA_PLATFORM_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}/platforms"
make

This comment has been minimized.

@ttuegel

ttuegel Jul 20, 2020
Member

I'm not sure why setting QT_PLUGIN_PATH isn't sufficient, and it should be OK to set these in preBuild, but I don't see anything wrong with this.

@stale stale bot removed the 2.status: stale label Jul 20, 2020

sourceRoot = "code-r${version}/QtSpim";

nativeBuildInputs = [ bison flex qmake ];

This comment has been minimized.

@ttuegel

ttuegel Jul 20, 2020
Member

Please add wrapQtAppsHook to nativeBuildInputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.