Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] firefox 71 #75006

Merged
merged 8 commits into from Dec 5, 2019
Merged

[19.09] firefox 71 #75006

merged 8 commits into from Dec 5, 2019

Conversation

@andir
Copy link
Member

@andir andir commented Dec 5, 2019

Motivation for this change

Stable version of #74905

This shouldn't rebuild the world and still work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @taku0

andir added 8 commits Dec 4, 2019
For the new Firefox 70 release we need a newer NSS version.
(cherry picked from commit 8eb6c64)
(cherry picked from commit ba1acd2)
(cherry picked from commit bbb74cd)
(Cherry picked from ff0cd02)
(cherry picked from commit 1993a8b)
@andir andir requested a review from taku0 Dec 5, 2019
@andir andir changed the title [19.09]firefox 71 [19.09] firefox 71 Dec 5, 2019
@ofborg ofborg bot requested a review from edolstra Dec 5, 2019
@andir
Copy link
Member Author

@andir andir commented Dec 5, 2019

I ran nix-review locally and tested firefox locally. Looked good.

@andir andir merged commit 0322870 into NixOS:release-19.09 Dec 5, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nspr_4_23, nss_3_47_1 on aarch64-linux Success
Details
nspr_4_23, nss_3_47_1 on x86_64-darwin Success
Details
nspr_4_23, nss_3_47_1 on x86_64-linux Success
Details
@fpletz
Copy link
Member

@fpletz fpletz commented Dec 7, 2019

Reverted for now due to #74905 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.