Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdgmenumaker: use python3 for NixOS#74295 #75015

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Dec 5, 2019

Motivation for this change

Use python3 and pygobject3 instead of python2 and pygtk. See #74295.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 5, 2019

@romildo Got rid of the custom installPhase with flags.

Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM, thanks 👍

@worldofpeace worldofpeace merged commit bc471c1 into NixOS:master Dec 5, 2019
@romildo romildo deleted the romildo:fix.xdgmenumaker branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.