Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnftnl,nftables,iptables,ebtables: bumpers #75026

Merged
merged 4 commits into from Dec 10, 2019

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Dec 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dtzWill added 4 commits Dec 3, 2019
@ofborg ofborg bot requested a review from fpletz Dec 5, 2019
@FRidh FRidh added this to Needs review in Staging Dec 5, 2019
@FRidh FRidh merged commit 868972f into NixOS:staging Dec 10, 2019
16 checks passed
16 checks passed
ebtables, iptables, libnftnl, nftables on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
ebtables, iptables, libnftnl, nftables on aarch64-linux Success
Details
ebtables, iptables, libnftnl, nftables on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Needs review to Done Dec 10, 2019
@andersk
Copy link
Contributor

@andersk andersk commented Dec 27, 2019

This renamed the ebtables binary to ebtables-legacy and broke libvirtd (#75878).

andir added a commit to andir/nixpkgs that referenced this pull request Jan 12, 2020
With the bump of iptables (NixOS#75026) ebtables was renamed from `ebtables`
to `ebtables-legacy`. libvirtd requires this binary to be availabe to
configure the host networking.

fixes NixOS#75878
@andir andir mentioned this pull request Jan 12, 2020
2 of 10 tasks complete
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 22, 2020
With the bump of iptables (NixOS#75026) ebtables was renamed from `ebtables`
to `ebtables-legacy`. libvirtd requires this binary to be availabe to
configure the host networking.

fixes NixOS#75878

(cherry picked from commit 22388a5)
offlinehacker added a commit to xtruder/nixpkgs that referenced this pull request Sep 14, 2020
With the bump of iptables (NixOS#75026) ebtables was renamed from `ebtables`
to `ebtables-legacy`. libvirtd requires this binary to be availabe to
configure the host networking.

fixes NixOS#75878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.