Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

heimer: init at 1.12.0 #75029

Merged
merged 4 commits into from Jan 1, 2020
Merged

heimer: init at 1.12.0 #75029

merged 4 commits into from Jan 1, 2020

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Dec 5, 2019

Motivation for this change

"Simple cross-platform mind map and note-taking tool written in Qt"

馃槆 meant to submit this earlier, but better later than never!
Enjoy!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dtzWill added 3 commits Aug 20, 2019
Copy link
Contributor

@doronbehar doronbehar left a comment

Commented.

pkgs/applications/misc/heimer/default.nix Outdated Show resolved Hide resolved
@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Jan 1, 2020

The use of mkDerivation is so that wrapping is done correctly since this is a qt app.

I'll simplify rev to what you suggest as it's cleaner and probably better supported -- the refs/tags/ bit is to ensure the tag is used not a branch that may have that name (habit picked up after seeing this happen a time or three :)).

It doesn't seem to generally be a problem, I should probably start doing it that way by default O:).

Suggested by @doronbehar in PR review, thanks!
@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Jan 1, 2020

Thanks! <3

@dtzWill dtzWill merged commit 7e5334d into NixOS:master Jan 1, 2020
16 checks passed
16 checks passed
heimer on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
heimer on aarch64-linux Success
Details
heimer on x86_64-linux Success
Details
@dtzWill dtzWill deleted the dtzWill:feature/heimer branch Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.