Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgcli: 2.1.1 -> 2.2.0 #75032

Merged
merged 2 commits into from Dec 5, 2019
Merged

pgcli: 2.1.1 -> 2.2.0 #75032

merged 2 commits into from Dec 5, 2019

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Dec 5, 2019

Motivation for this change

Changelog: https://github.com/dbcli/pgcli/blob/v2.2.0/changelog.rst#220

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam requested review from FRidh and jonringer as code owners Dec 5, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 5, 2019
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

[8 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75032
5 package were built:
pgcli python27Packages.pgspecial python37Packages.pgspecial python38Packages.pgcli python38Packages.pgspecial
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 5, 2019

@GrahamcOfBorg build pgcli python27Packages.pgspecial python37Packages.pgspecial python38Packages.pgcli python38Packages.pgspecial

@dywedir
Copy link
Member

@dywedir dywedir commented Dec 5, 2019

Thanks!

@dywedir dywedir merged commit ca7272d into NixOS:master Dec 5, 2019
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pgcli on aarch64-linux Success
Details
pgcli on x86_64-linux Success
Details
pgcli, python27Packages.pgspecial, python37Packages.pgspecial, python38Packages.pgcli, python38Packages.pgspecial on aarch64-linux Success
Details
pgcli, python27Packages.pgspecial, python37Packages.pgspecial, python38Packages.pgcli, python38Packages.pgspecial on x86_64-darwin Success
Details
pgcli, python27Packages.pgspecial, python37Packages.pgspecial, python38Packages.pgcli, python38Packages.pgspecial on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.