Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build phpPackages #75033

Closed
wants to merge 5 commits into from
Closed

Update build phpPackages #75033

wants to merge 5 commits into from

Conversation

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 5, 2019

Motivation for this change

Fixed error:

./configure: line 5836: /usr/bin/file: No such file or directory

Clean-ip build configuration.

cc @etu @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin Izorkin requested a review from etu as a code owner Dec 5, 2019
@ofborg ofborg bot requested review from javaguirre and jtojnar Dec 5, 2019
@Izorkin Izorkin force-pushed the Izorkin:phpPackages-build branch 2 times, most recently from 8c56d88 to a076b0b Dec 6, 2019
@Izorkin Izorkin force-pushed the Izorkin:phpPackages-build branch 2 times, most recently from 6b82db2 to b320bda Feb 22, 2020
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Feb 22, 2020

Updated and rebased.
cc @etu @aanderse @Mic92

@Izorkin Izorkin force-pushed the Izorkin:phpPackages-build branch from b320bda to 5a7155d Feb 22, 2020
@ofborg ofborg bot requested review from ajs124 and dasJ Feb 22, 2020
@ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 22, 2020

For which package(s) does ./configure: line 5836: /usr/bin/file: No such file or directory actually lead to a build error? Because I think I've seen that a whole bunch of times, but it always seemed like a harmless warning.

@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Feb 22, 2020

Only removed this warning. How this error affects the building I do not know.

@etu
Copy link
Contributor

@etu etu commented Feb 24, 2020

@Izorkin Sorry, but I don't see the point of this PR if it actually doesn't fix any real error.

If we have a package that is broken due to this, it's worth doing. But this touch so many places to get rid of something that seems to be harmless...

@etu etu closed this Feb 24, 2020
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Feb 25, 2020

@etu reakky merge this commit? - bb798c0

@etu
Copy link
Contributor

@etu etu commented Feb 26, 2020

@Izorkin Since that commit only would add file as an additional dependency to the closure but not actually resolve any issue (that we know of)... I don't see the point of merging it.

@aanderse
Copy link
Contributor

@aanderse aanderse commented Feb 26, 2020

I agree with @etu that we should be solving a known problem when we increase closure size, not appeasing a warning which has no known issue.

I would also point out that many packages mention a missing file executable, so conceivable this is an "issue" (or non issue) with 1 or more build systems. If this is an actual problem which requires solving we should look to solve it tree wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.