Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkitgtk: cleanups #75043

Merged
merged 3 commits into from Dec 11, 2019
Merged

webkitgtk: cleanups #75043

merged 3 commits into from Dec 11, 2019

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace force-pushed the worldofpeace:webkitgtk-parallel branch from bb65cdc to 2e4f9be Dec 5, 2019
@worldofpeace worldofpeace changed the title webkitgtk: enableParallelBuilding webkitgtk: cleanups Dec 5, 2019
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Dec 5, 2019

@pbogdan ok soo... We'll just pretend that didn't happen 😄

Some weeks it's like this.

@worldofpeace worldofpeace force-pushed the worldofpeace:webkitgtk-parallel branch from 2e4f9be to ed3ffa1 Dec 11, 2019
@worldofpeace worldofpeace merged commit 58cf77f into NixOS:master Dec 11, 2019
2 of 4 checks passed
2 of 4 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace worldofpeace deleted the worldofpeace:webkitgtk-parallel branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.