Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gst_all_1.gst-plugins-base: Fix building Wayland support (nullglob fail) #75046

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 5, 2019

Apparently, generic builder sets nullglob, disappearing any flags containing square brackets not resolving to file names (e.g. mesonFlags = [ "-Dgl_winsys=[x11,wayland]" ];). This caused the gl_winsys flag default to auto and, since we were missing wayland-protocols, Wayland support was not built.

Fortunately, Meson also supports simple array notation without square brackets, so we can use that. No need to wait for _structuredAttrs.

We also no longer set gl_platform flag, since passing the default auto value is redundant.

cc @Ma27, @Ericson2314, @globin (d29bcfa#r345472380)

Apparently, generic builder sets `nullglob`, disappearing any flags containing square brackets
not resolving to file names (e.g. `mesonFlags = [ "-Dgl_winsys=[x11,wayland]" ];`). This caused
the `gl_winsys` flag default to `auto` and, since we were missing `wayland-protocols`, Wayland
support was not built.

Fortunately, Meson also supports simple array notation without square brackets, so we can use
that. No need to wait for `_structuredAttrs`.

We also no longer set `gl_platform` flag, since passing the default auto value is redundant.
@jtojnar jtojnar force-pushed the jtojnar:gst/wayland branch from 1b2376a to 5a139f0 Dec 5, 2019
@Ma27
Ma27 approved these changes Dec 6, 2019
Copy link
Member

@Ma27 Ma27 left a comment

LGTM. Would be cool if you could do styling fixes in a separate commit though :)

@Ma27 Ma27 merged commit 6fda860 into NixOS:staging Dec 6, 2019
16 checks passed
16 checks passed
gst_all_1.gst-plugins-base on x86_64-darwin Timed out, unknown build status
Details
gst_all_1.gst-plugins-base on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
gst_all_1.gst-plugins-base on aarch64-linux Success
Details
@jtojnar jtojnar deleted the jtojnar:gst/wayland branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.