Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/borgbackup: add option to make systemd timer persistent #75056

wants to merge 1 commit into
base: master


Copy link

@feijoas feijoas commented Dec 5, 2019

Setting the systemd-timer option Persisten=true guarantees the backup if it missed a run due to the machine being off.

Copy link

@Ma27 Ma27 left a comment

LGTM. Would be great if you could improve the docs a bit, but apart from that, this patch should be good to go :)

nixos/modules/services/backup/borgbackup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/borgbackup.nix Outdated Show resolved Hide resolved
Copy link
Contributor Author

@feijoas feijoas commented Dec 7, 2019

Is persistent the option name we wanna use? It may not be obvious that this is a option for the timer and not borgbackup.

@feijoas feijoas force-pushed the feijoas:borgbackup_persistent branch from dbc95a2 to 3cf535c Dec 7, 2019
Copy link

@mweinelt mweinelt commented Mar 8, 2020

Then maybe call it persistentTimer to point to the relationship with the timer unit.

Copy link

@stale stale bot commented Sep 4, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.